Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more selectors of the blocks api for the mobile app #12383

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Add more selectors of the blocks api for the mobile app #12383

merged 1 commit into from
Nov 28, 2018

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Nov 28, 2018

Description

This PR exposes more functions to the react native app.
Required for wordpress-mobile/gutenberg-mobile#276

Exposing:

  • getFreeformContentHandlerName
  • isUnmodifiedDefaultBlock

Types of changes

  • React native update

@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 28, 2018
@Tug Tug self-assigned this Nov 28, 2018
@Tug Tug requested a review from pinarol November 28, 2018 13:41
pinarol
pinarol approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against wordpress-mobile/gutenberg-mobile#276

@Tug Tug merged commit 3b5ab7b into master Nov 28, 2018
@Tug Tug deleted the rnmobile/add/blocks-exports branch November 28, 2018 13:58
@youknowriad youknowriad added this to the 4.7 milestone Nov 29, 2018
@mtias mtias modified the milestones: 4.7, Mobile Alpha Dec 6, 2018
@MaxMood96 MaxMood96 mentioned this pull request Mar 7, 2024
Open
@naiba4 naiba4 mentioned this pull request Mar 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

@Tug Tug

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Mobile Alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@Tug @pinarol @youknowriad @mtias